Mix EA into DTA/TDA; part of 24024 #24502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Refactor
|
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #24502 +/- ##
===========================================
- Coverage 92.31% 43.05% -49.27%
===========================================
Files 166 166
Lines 52391 52400 +9
===========================================
- Hits 48363 22559 -25804
- Misses 4028 29841 +25813
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24502 +/- ##
==========================================
+ Coverage 92.31% 92.31% +<.01%
==========================================
Files 166 166
Lines 52391 52400 +9
==========================================
+ Hits 48363 48372 +9
Misses 4028 4028
Continue to review full report at Codecov.
|
|
ping |
|
thanks |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nearly all of the remaining DTA/TDA changes in #24024. The things that are not included:
value_countsfrom 24024 has small change to make sure the tz-aware case is correct regardless of how the constructor changes in 24024 get resolved. A test is added specifically to check for this.The changes implied by mixing ExtensionArray into DatetimeLikeArrayMixin are not tested yet, won't be until the extension tests part of #24024 is merged. I don't see any way around that except for doing 24024 all at once.